Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AsyncInstrumentRegistry after update to SDK 1.12 #5525

Merged

Conversation

mateuszrzeszutek
Copy link
Member

This PR depends on #5452 - without it a couple of tests are failing.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team March 8, 2022 08:50
@mateuszrzeszutek mateuszrzeszutek force-pushed the remove-AsyncInstrumentRegistry branch from bfc99d0 to 4d2aa5a Compare March 9, 2022 09:00
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @mateuszrzeszutek and @jack-berg!

@trask trask added this to the v1.12.0 milestone Mar 9, 2022
@anuraaga anuraaga merged commit 0ad07a1 into open-telemetry:main Mar 10, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the remove-AsyncInstrumentRegistry branch March 10, 2022 10:19
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
…ry#5525)

* Remove AsyncInstrumentRegistry after update to SDK 1.12

* added comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants