Disable the messaging receive span telemetry by default #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Mar 5, 2022
|
closing and re-opening, b/c retriggering build manually doesn't seem to pick up the |
|
oh I forgot, |
…emetry-by-default
anuraaga
approved these changes
Mar 7, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…ry#5500) * Disable the messaging receive span telemetry by default * fix spring-kafka tests * remove no longer needed link from the kafka-clients library instrumentation Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5385
I introduced a new property for this (
otel.instrumentation.messaging.experimental.receive-telemetry.enabled) - I figured that in case somebody wants to turn it on it probably makes more sense to sayenabled=truethansuppress=false. And the majority of our properties use the...enabledform, there's only a few using...suppress.