Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support forwarded proto field and x-forwarded-proto #5357

Merged
merged 8 commits into from
Feb 22, 2022
Merged

Support forwarded proto field and x-forwarded-proto #5357

merged 8 commits into from
Feb 22, 2022

Conversation

trask
Copy link
Member

@trask trask commented Feb 11, 2022

Resolves #2958

I've opened spec issue to ask about this: open-telemetry/opentelemetry-specification#2338

If there's any objection to merging this change before getting spec clarification I can hide it behind an experimental flag.

@trask trask requested a review from a team February 11, 2022 20:20
@trask trask merged commit 23ec767 into open-telemetry:main Feb 22, 2022
@trask trask deleted the forwarded-proto branch February 22, 2022 21:01
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
)

* Renames for the better

* Support forwarded proto

* fix

* Fix checkstyle complaining about abbrevation

* checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture the request scheme from Forwarded or X-Forwarded-Proto headers if available
3 participants