Use repository interface name in spring data operation name #5352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Feb 11, 2022
.../io/opentelemetry/javaagent/instrumentation/spring/data/SpringDataInstrumentationModule.java
Outdated
Show resolved
Hide resolved
…/io/opentelemetry/javaagent/instrumentation/spring/data/SpringDataInstrumentationModule.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
trask
approved these changes
Feb 11, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…emetry#5352) * Use repository interface name in spring data operation name * Update instrumentation/spring/spring-data-1.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/data/SpringDataInstrumentationModule.java Co-authored-by: Mateusz Rzeszutek <[email protected]> * spotless Co-authored-by: Mateusz Rzeszutek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently spring data operation name uses the declaring class of the invoked method. The problem with this is that some of these methods are defined in multiple interfaces and which makes the test flaky. https://ge.opentelemetry.io/s/xd5i7f7go3hh2/tests/:instrumentation:spring:spring-data-1.8:javaagent:test/SpringJpaTest/test%20CRUD?top-execution=1
Additionally both
JpaRepositoryandCrudRepositorythat are usually used in operation name are really spring data classes which makes the operation name a bit useless. This pr changes the repository name to use the actual repository interface.