Change the way Micrometer LongTaskTimer is bridged #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Feb 11, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the previous way of reporting
LongTaskTimermeasurements, the one using a histogram, was wrong. As the example from #5292 (comment) shows, for long running task you might want to set up aLongTaskTimerfor currently running tasks and a separateTimerfor ones that have already finished - so reporting metrics for finished tasks inLongTaskTimerwould result in duplicate metrics; and would not show the durations of tasks in progress. I removed the OTel histogram usage fromLongTaskTimer; now it only reports metrics for tasks in progress (which should be consistent with all otherLongTaskTimerimplementations).