Avoid having two tasks producing the same file #5334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
force-pushed
the
jar-noshadow
branch
from
18fb9ab to
c3192cc
Compare
anuraaga
commented
Feb 10, 2022
| @@ -218,6 +218,25 @@ tasks { | |||
| named("generateLicenseReport").configure { | |||
| dependsOn(cleanLicenses) | |||
| } | |||
|
|
|||
| // Because we reconfigure publishing to only include the shadow jar, the Gradle metadata is not correct. | |||
There was a problem hiding this comment.
This was actually already the case, causing awkwardness like this
mateuszrzeszutek
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
As #5333 already reduces the chance of a successful release, doesn't hurt to reduce it even further!
💯
😂
trask
approved these changes
Feb 10, 2022
Comment on lines
+233
to
+235
| withVariantsFromConfiguration(configurations["apiElements"]) { | ||
| skip() | ||
| } |
There was a problem hiding this comment.
what is in apiElements that we suppress?
There was a problem hiding this comment.
I was surprised too but for some reason the jar seems to be in both API and runtime elements
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #5333 already reduces the chance of a successful release, doesn't hurt to reduce it even further!
Note,
publishToMavenLocallooks reasonable except for the lack of-base. But as far as I can tell,-basewasn't working before this PR as wellhttps://repo1.maven.org/maven2/io/opentelemetry/javaagent/opentelemetry-javaagent/1.10.1/