Add max measurements to Micrometer Timer & DistributionSummary #5303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Feb 8, 2022
anuraaga
approved these changes
Feb 8, 2022
|
|
||
| // when | ||
| Metrics.globalRegistry.remove(timer); | ||
| Thread.sleep(10); // give time for any inflight metric export to be received |
There was a problem hiding this comment.
Will be able to remove this after #5314 I think
There was a problem hiding this comment.
I'm guessing there may still be a tiny window while the metric sdk is still collecting metrics but before it has sent them to the metric exporter(?)
There was a problem hiding this comment.
At time of writing, that PR was causing clearData to first flush the metrics SDK. But realized it's not necessary or helpful in most tests so changed it back, so indeed this comment is now invalid
There was a problem hiding this comment.
oh i c, it flushed the full collection cycle, not just the export? that does seem useful for all of these micrometer unregister tests that we have
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one of the issues discovered in #5292