Fix serialization fo quartz JobExecutionContext #5263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Jan 28, 2022
Comment on lines
18
to
21
| private static final VirtualField<JobExecutionContext, Context> contextVirtualField = | ||
| VirtualField.find(JobExecutionContext.class, Context.class); | ||
| private static final VirtualField<JobExecutionContext, Scope> scopeVirtualField = | ||
| VirtualField.find(JobExecutionContext.class, Scope.class); |
There was a problem hiding this comment.
WDYT about making a ContextAndScope class and using just one virtual field?
mateuszrzeszutek
approved these changes
Jan 28, 2022
trask
approved these changes
Jan 28, 2022
Comment on lines
+125
to
+127
| // ensure that JobExecutionContext is serializable | ||
| try { | ||
| new ObjectOutputStream(new ByteArrayOutputStream()).writeObject(context); |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Fix serialization fo quartz JobExecutionContext * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5243