Actually fix redisson instrumentation after 3.16.8 release #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
approved these changes
Jan 21, 2022
|
You still need to have different advice classes for these two - except the method matcher there's pretty much nothing in common. |
laurit
approved these changes
Jan 21, 2022
Ah yeah, didn't consider that we still need two advices because we don't control creation of them (and just pass the name as a string). Gotcha. |
trask
reviewed
Jan 22, 2022
.../java/io/opentelemetry/javaagent/instrumentation/redisson/RedissonInstrumentationModule.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
actually-fix-redisson-3.16.8
branch
from
015244e to
0c36f17
Compare
That could work too! I reworked this PR to use |
anuraaga
approved these changes
Jan 24, 2022
...agent/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/RedissonRequest.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Jan 24, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…metry#5201) * Actually fix redisson instrumentation after 3.16.8 release * try MethodHandles * remove unneeded virtual fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Lauri's idea of using
VirtualFields to avoid callinggetPromise()