-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always set parent of agent class loader to bootstrap class loader #5169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
public static boolean isJavaBefore9() { | ||
return System.getProperty("java.version").startsWith("1."); | ||
private static ClassLoader createAgentClassLoader(String innerJarFilename, File javaagentFile) { | ||
return new AgentClassLoader(javaagentFile, innerJarFilename, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to keep the parent
argument in the constructor?
f9ece06
to
56f62b5
Compare
agentParent = null; // bootstrap | ||
} else { | ||
// platform classloader is parent of system in java 9+ | ||
agentParent = getPlatformClassLoader(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why we were doing this before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was inherited, my best guess is for access to java.sql
package for some reason(?)
…en-telemetry#5169) * Always set parent of agent class loader to bootstrap class loader * remove parent class loader argument
Resolves #5156