fix(aws-sdk): use RPC attributes from spec

[blumamir]

Fix #5159

For aws-sdk-1.11 and aws-sdk-2.2 instrumentations:

• Rename aws.service to rpc.service according to the spec.
• Rename aws.operation to rpc.method according to the spec.
• Add missing attribute from spec: rpc.system
• The above rpc attributes are always published, unlike the aws.* attributes which are set only when otel.instrumentation.aws-sdk.experimental-span-attributes=true
• Renamed AwsSdkAttributesExtractor.java to AwsSdkHttpAttributesExtractor.java, to make it consistent with the other extractors in the module. This extractor is extracting http client attributes only, and not aws-sdk domain attributes.
• Fixed the tests to use the new attributes and removed the old non-spec-compliant names

This is my first PR in java, so please take a good look.

[blumamir]

A test seems to fail in CI (PR build / test (15, openj9) (pull_request) Failing after 29m — test (15, openj9)), but I don't think it's related to my changes:

 Task :instrumentation:spring:spring-rmi-4.0:javaagent:test

SpringRmiTest > Client call creates spans FAILED
    java.rmi.ConnectException: Connection refused to host: 10.1.0.130; nested exception is: 
    	java.net.ConnectException: Connection timed out
        at [email protected]/sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:623)
        at [email protected]/sun.rmi.transport.tcp.TCPChannel.createConnection(TCPChannel.java:209)
        at [email protected]/sun.rmi.transport.tcp.TCPChannel.newConnection(TCPChannel.java:196)
        at [email protected]/sun.rmi.server.UnicastRef.invoke(UnicastRef.java:132)
        at [email protected]/java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(RemoteObjectInvocationHandler.java:217)
        at [email protected]/java.rmi.server.RemoteObjectInvocationHandler.invoke(RemoteObjectInvocationHandler.java:162)
        at app//org.springframework.remoting.rmi.RmiClientInterceptor.doInvoke(RmiClientInterceptor.java:399)
        at app//org.springframework.remoting.rmi.RmiClientInterceptor.doInvoke(RmiClientInterceptor.java:345)
        at app//org.springframework.remoting.rmi.RmiClientInterceptor.invoke(RmiClientInterceptor.java:260)
        at app//org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
        at app//org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:207)
        at SpringRmiTest.Client call creates spans_closure1(SpringRmiTest.groovy:72)
        at SpringRmiTest.Client call creates spans_closure1(SpringRmiTest.groovy)
        at app//groovy.lang.Closure.call(Closure.java:412)
        at app//io.opentelemetry.instrumentation.testing.TestInstrumenters.runWithInstrumenter(TestInstrumenters.java:84)
        at app//io.opentelemetry.instrumentation.testing.TestInstrumenters.runWithSpan(TestInstrumenters.java:44)
        at app//io.opentelemetry.instrumentation.testing.InstrumentationTestRunner.runWithSpan(InstrumentationTestRunner.java:119)
        at app//io.opentelemetry.instrumentation.test.InstrumentationSpecification.runWithSpan(InstrumentationSpecification.groovy:120)
        at SpringRmiTest.Client call creates spans(SpringRmiTest.groovy:72)

        Caused by:
        java.net.ConnectException: Connection timed out
            at [email protected]/sun.nio.ch.Net.connect(Net.java:574)
            at [email protected]/sun.nio.ch.Net.connect(Net.java:563)
            at [email protected]/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:588)
            at [email protected]/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:333)
            at [email protected]/java.net.Socket.connect(Socket.java:648)
            at [email protected]/java.net.Socket.connect(Socket.java:597)
            at [email protected]/java.net.Socket.<init>(Socket.java:520)
            at [email protected]/java.net.Socket.<init>(Socket.java:294)
            at [email protected]/sun.rmi.transport.tcp.TCPDirectSocketFactory.createSocket(TCPDirectSocketFactory.java:40)
            at [email protected]/sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:617)
            ... 18 more

Is it just flacky test? should I ignore it?

[mateuszrzeszutek]

Is it just flacky test? should I ignore it?

Yes, that's just a flaky test that's been introduced very recently - don't worry about it. I'll rerun the checks on your branch just in case.

[anuraaga]

Thanks!