Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't capture http.target as metrics attribute #5081

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Don't capture http.target as metrics attribute #5081

merged 1 commit into from
Jan 12, 2022

Conversation

trask
Copy link
Member

@trask trask commented Jan 12, 2022

Resolves #5047

Introduces experimental attribute otel.instrumentation.metrics.experimental.use-http-target-fallback to re-enable capturing of http.target when http.route is unavailable, primarily for testing purposes until http.route is captured consistently.

@trask trask requested a review from a team January 12, 2022 01:11
@iNikem iNikem merged commit b8ea362 into open-telemetry:main Jan 12, 2022
@trask trask deleted the remove-http-target-attribute branch January 12, 2022 16:38
@trask trask mentioned this pull request Apr 5, 2022
Closed
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@trask @RashmiRam
Don't capture http.target as metrics attribute (open-telemetry#5081)
f1f4efa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@iNikem iNikem iNikem approved these changes

@anuraaga anuraaga anuraaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove http.target from metric attributes to control cardinality
4 participants
@trask @anuraaga @iNikem @mateuszrzeszutek