Add logback appender javaagent instrumentation #4939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
anuraaga
reviewed
Dec 20, 2021
We already have library instrumentation for log4j. @jack-berg mentioned last week he was working on (or thinking about writing?) a logback appender. |
|
created #4947 to track adding a logback appender instrumentation module |
…-javaagent-instrumentation
anuraaga
approved these changes
Dec 20, 2021
...ain/java/io/opentelemetry/javaagent/instrumentation/logback/appender/v1_0/LogbackHelper.java
Outdated
Show resolved
Hide resolved
...ain/java/io/opentelemetry/javaagent/instrumentation/logback/appender/v1_0/LogbackHelper.java
Outdated
Show resolved
Hide resolved
…n/java/io/opentelemetry/javaagent/instrumentation/logback/appender/v1_0/LogbackHelper.java Co-authored-by: Anuraag Agrawal <[email protected]>
…n/java/io/opentelemetry/javaagent/instrumentation/logback/appender/v1_0/LogbackHelper.java Co-authored-by: Anuraag Agrawal <[email protected]>
mateuszrzeszutek
approved these changes
Dec 20, 2021
instrumentation/logback/logback-appender-1.0/javaagent/src/test/groovy/LogbackTest.groovy
Show resolved
Hide resolved
Comment on lines
+90
to
+94
| logger = args[0] | ||
| loggerName = args[1] | ||
| testMethod = args[2] | ||
| severity = args[3] | ||
| severityText = args[4] |
There was a problem hiding this comment.
Would
Suggested change
| logger = args[0] | |
| loggerName = args[1] | |
| testMethod = args[2] | |
| severity = args[3] | |
| severityText = args[4] | |
| [logger, loggerName, testMethod, severity, severityText] = args |
work?
There was a problem hiding this comment.
almost! it looks like def (logger, loggerName, testMethod, severity, severityText) = args should work, but not in where blocks:
where-blocks may only contain parameterizations (e.g. 'salary << [1000, 5000, 9000]; salaryk = salary / 1000')
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* logback * Use assertInverse * sync * sync * Update instrumentation/logback/logback-appender-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/logback/appender/v1_0/LogbackHelper.java Co-authored-by: Anuraag Agrawal <[email protected]> * Update instrumentation/logback/logback-appender-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/logback/appender/v1_0/LogbackHelper.java Co-authored-by: Anuraag Agrawal <[email protected]> * Unroll Co-authored-by: Anuraag Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
logback-1.0instrumentation module tologback-mdc-1.0, and introduceslogback-appender-1.0module.There's no autoconfiguration of log exporter (yet), so this instrumentation doesn't benefit end users unless they explicitly configure a logging exporter via javaagent extension (this is how the tests work).