Update log4j instrumentation docs #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Dec 16, 2021
iNikem
approved these changes
Dec 16, 2021
…y-base-version-docs
iNikem
approved these changes
Dec 17, 2021
|
moving to draft to avoid accidentally merging early |
…y-base-version-docs
iNikem
reviewed
Dec 20, 2021
| @@ -22,7 +22,7 @@ To use it, add the module to your application's runtime classpath. | |||
|
|
|||
| ```kotlin | |||
| dependencies { | |||
| runtimeOnly("io.opentelemetry.instrumentation:opentelemetry-log4j-2.13.2:0.17.0-alpha") | |||
| runtimeOnly("io.opentelemetry.instrumentation:opentelemetry-log4j-thread-context-2.16-autoconfigure:1.10.0-alpha") | |||
There was a problem hiding this comment.
Uhh, this makes me think about our naming schema...
jack-berg
approved these changes
Jan 3, 2022
…y-base-version-docs
Discussed in yesterday special topics meeting, and decided holding doc PRs until release is a hassle, and so |
trask
changed the title
anuraaga
approved these changes
Jan 5, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Update log4j instrumentation docs for 1.10.0 release * More log4j doc changes for 0.10.0 * Updates for open-telemetry#4937 * Fix log4j documentation * Update instrumentation/log4j/log4j-2.16/library/README.md Co-authored-by: jack-berg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc updates for #4914. This PR is split out if we want to merge during/after 1.10 release.
Or should I just include the doc updates in #4914 and tags can be used now for viewing stable release docs?