Reorganize shared servlet code (intro to #4317) #4785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
laurit
approved these changes
Dec 6, 2021
mateuszrzeszutek
force-pushed
the
reorganize-servlet-code
branch
from
465dd78 to
ede08a4
Compare
iNikem
approved these changes
Dec 6, 2021
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…elemetry#4785) * Reorganize shared servlet code (intro to open-telemetry#4317) * Fix dropwizard tests * fix compile error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4317 will introduce a bootstrap module that'll contain classes moved from
instrumentation-api. Library modules should not depend on a bootstrap module, because that's a javaagent only concept -- in fact, the whole servlet instrumentation should not have any library modules because a servlet library instrumentation does not exist.In this PR I moved some of those shared "library" classes around and removed the servlet library modules.