-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix incorrect delegate method #4630
fix incorrect delegate method #4630
Conversation
I believe you can modify this test Lines 337 to 347 in 4719e4c
to verify the fix. Just add something like assert it.span.instrumentationLibraryInfo.name == "test"
assert it.span.instrumentationLibraryInfo.version == "1.0" inside the |
Interesting. I was just trying to write a vanilla unit test, but that really did fail miserably, so this seems like a good consolation prize. I got it going, thanks for the suggestion. |
@@ -347,6 +347,7 @@ class TracerTest extends AgentInstrumentationSpecification { | |||
name "test" | |||
kind PRODUCER | |||
hasNoParent() | |||
instrumentationLibraryVersion "1.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* fix incorrect delegate method * add version test
resolves #4628
I tried writing a test, but the classloading stuff was too perilous and I gave up.