Remove hibernate session spans #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Oct 29, 2021
| } | ||
| } | ||
| sessionId1 != sessionId2 != sessionId3 |
Comment on lines
-70
to
-74
| add("version6TestImplementation", "org.hibernate:hibernate-core:6.0.0.Alpha6") | ||
| add("version6TestImplementation", "org.hibernate:hibernate-entitymanager:6.0.0.Alpha6") | ||
| add("version6TestImplementation", "org.springframework.data:spring-data-jpa:2.3.0.RELEASE") | ||
|
|
||
| // hibernate 6 is alpha so use 5 as latest version |
There was a problem hiding this comment.
is reason to delete this just to avoid maintenance prior to 6 being GA? (that works for me, just checking reason)
There was a problem hiding this comment.
The instrumentation actually failed muzzle for hibernate 6 so the only spring test we had didn't really test the instrumentation. The latest version for hibernate 6.0.0.Beta1 has changed to jakarta.perisistence api which would probably break the spring test too so I didn't see much point in keeping it.
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3552
Hibernate instrumentation placed all hibernate operations under a session span that spanned the whole hibernate session, which isn't consistent with rest of the instrumentations. This pr refactors hibernate instrumentation to behave like other instrumentations.