Fix context propagation in tomcat thread pool #4521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4497
Tomcat
ThreadPoolExecutor
extendsjava.util.concurrent.ThreadPoolExecutor
and overrides theexecute
method. It also uses a custom task queue that reports queue full when pool size is smaller than max. This makesj.u.c.ThreadPoolExecutor
create new threads. If maximum number of threads is reached thenj.u.c.ThreadPoolExecutor
will reject the task because it could not be queued (queue behaved as it is full) and thread could not be created. TomcatThreadPoolExecutor
catchesRejectedExecutionException
and places task in queue. The problem is that we clear propagated context whenj.u.c.ThreadPoolExecutor.execute
fails withRejectedExecutionException
because we interpret an exception inexecute
as a failure to queue task and assume that it could never execute.This pr alters context propagation handling so that when task already has expected context we just skip it and return null, which disables the cleanup on exception logic.
Hopefully this pr also gets rid of debug logs
Failed to propagate context because previous propagated context is
where new and old context are the same and have different debug locations.