Netty: preserve caught exception in the context instead of calling end() #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Oct 18, 2021
laurit
reviewed
Oct 18, 2021
| error = t; | ||
| throw t; | ||
| } finally { | ||
| error = NettyErrorHolder.getOrDefault(context, error); |
There was a problem hiding this comment.
Perhaps it is a bit debatable whether we should use the exception that is in context or the one that happened here. Could be fine either way.
There was a problem hiding this comment.
Yeah, I don't have any strong preference on one over another - I guess it's fine either way.
laurit
approved these changes
Oct 18, 2021
mateuszrzeszutek
force-pushed
the
netty-error-handling
branch
from
3b39584 to
07116fb
Compare
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.