Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename newBuilder() to builder() #4407

Merged
merged 2 commits into from
Oct 18, 2021
Merged

rename newBuilder() to builder() #4407

merged 2 commits into from
Oct 18, 2021

Conversation

MartinDai
Copy link
Contributor

rename newBuilder() to builder()
#4392

trask
trask approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@MartinDai
Copy link
Contributor Author

the check PR build / smoke-test (ubuntu-latest, wildfly) was failed, It seems to be caused by the build environment
@trask @iNikem Can you confirm it for me?

@mateuszrzeszutek mateuszrzeszutek linked an issue Oct 18, 2021 that may be closed by this pull request
Rename all newBuilder() method to builder() #4392
Closed
@mateuszrzeszutek mateuszrzeszutek removed a link to an issue Oct 18, 2021
Rename all newBuilder() method to builder() #4392
Closed
@mateuszrzeszutek
Copy link
Member

It does seem like an environmental thing; I re-ran the checks, hope they pass this time.
And thanks!

@trask trask merged commit 6d9e361 into open-telemetry:main Oct 18, 2021
@iNikem iNikem mentioned this pull request Oct 20, 2021
Closed
@MartinDai MartinDai deleted the rename-builder branch October 22, 2021 14:18
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@MartinDai @RashmiRam
rename newBuilder() to builder() (open-telemetry#4407)
7d173a9 
* rename `newBuilder()` to `builder()`

* code format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@iNikem iNikem iNikem approved these changes

@trask trask trask approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jkwatson jkwatson Awaiting requested review from jkwatson

@laurit laurit Awaiting requested review from laurit

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinDai @mateuszrzeszutek @trask @iNikem