Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test captured HTTP headers - HTTP server tests, part 2 #4328

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Test captured HTTP headers - HTTP server tests, part 2 #4328

merged 3 commits into from
Oct 8, 2021

Conversation

mateuszrzeszutek
Copy link
Member

Covered all other HTTP server tests -- except netty-based ones, but netty still uses Tracer so it doesn't capture headers

trask
trask approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 3546996 into open-telemetry:main Oct 8, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the test-captured-http-headers-server-part-2 branch October 9, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@trask trask trask approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateuszrzeszutek @trask @laurit