Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.6.x branch: revert breaking muzzle changes #4245

Merged
merged 3 commits into from
Sep 29, 2021
Merged

v1.6.x branch: revert breaking muzzle changes #4245

merged 3 commits into from
Sep 29, 2021

Conversation

trask
Copy link
Member

@trask trask commented Sep 29, 2021 •
edited
Loading

See #4244

This PR has three commits:

  • Straight revert of the problematic cherry-pick which introduced breaking changes for extensions
  • Fresh and partial cherry-pick of Remove muzzle from gradleplugins #4183, including the composite build (which solves the problem of the v1.6.0 tag being built against a snapshot version of gradle-plugins), but excluding package renames for muzzle classes that are used at runtime.
  • Cherry-pick of Restrict kafka-streams to 2.x versions for now #4173 which is needed due to new kafka-streams release

@trask trask changed the title Revert problematic muzzle changes v1.6.x branch: revert problematic muzzle changes Sep 29, 2021
@trask trask changed the title v1.6.x branch: revert problematic muzzle changes v1.6.x branch: revert breaking muzzle changes Sep 29, 2021
@trask trask marked this pull request as ready for review September 29, 2021 22:09
@trask
Copy link
Member Author

trask commented Sep 29, 2021

I tested this manually against an extension built against 1.6.0

@trask trask merged commit 7e744a4 into open-telemetry:v1.6.x Sep 29, 2021
@trask trask deleted the v1.6.x branch September 29, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson jkwatson is a code owner

@laurit laurit Awaiting requested review from laurit laurit is a code owner

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @anuraaga