Make servlet context path key private #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
trask
reviewed
Sep 15, 2021
| } | ||
| return context; | ||
| protected Context addServletContextPath(Context context, REQUEST request) { | ||
| return ServletContextPath.init(context, () -> accessor.getRequestContextPath(request)); |
There was a problem hiding this comment.
can we do non-capturing lambda here similar to #4014?
Comment on lines
-25
to
+26
| public static final ContextKey<String> CONTEXT_KEY = | ||
| private static final ContextKey<ServletContextPath> CONTEXT_KEY = |
There was a problem hiding this comment.
do we need the ServletContextPath wrapper object?
There was a problem hiding this comment.
Using wrapper helps to distinguish context path not yet set from context path empty. I guess I could use "" to mark empty context path.
mateuszrzeszutek
approved these changes
Sep 15, 2021
.../library/src/main/java/io/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java
Outdated
Show resolved
Hide resolved
…o/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
trask
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a review comment from #4078