Allow adding multiple ContextStore fields to one key class, part 1 #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Sep 9, 2021
|
|
||
| public boolean hasMapping(String keyClassName, String contextClassName) { | ||
| return entrySet.contains( | ||
| new AbstractMap.SimpleImmutableEntry<>(keyClassName, contextClassName)); |
There was a problem hiding this comment.
i didn't know about this public Map.Entry implementation!
There was a problem hiding this comment.
I just learned about it yesterday too 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using a
Map<String, String>to store theContextStoremappings for a single instrumentation, but that doesn't really work when you need to add >1 context field in a single instrumentation module (because the map value will be overwritten).This is only the first PR, containing just API/agent changes -- muzzle codegen plugin changes will be added in the next one(s).