Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension shading #4064

Merged
merged 1 commit into from
Sep 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.example.javaagent;

import com.google.auto.service.AutoService;
import io.opentelemetry.instrumentation.api.config.Config;
import io.opentelemetry.javaagent.extension.ignore.IgnoredTypesBuilder;
import io.opentelemetry.javaagent.extension.ignore.IgnoredTypesConfigurer;

/**
* Custom {@link IgnoredTypesConfigurer} which exists currently only to verify correct shading.
*
* @see io.opentelemetry.javaagent.extension.ignore.IgnoredTypesConfigurer
*/
@AutoService(IgnoredTypesConfigurer.class)
public class DemoIgnoredTypesConfigurer implements IgnoredTypesConfigurer {

@Override
public void configure(Config config, IgnoredTypesBuilder builder) {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class RemappingUrlConnection extends URLConnection {
"#io.opentelemetry.javaagent.shaded.io.opentelemetry.context"),
rule(
"#io.opentelemetry.instrumentation",
"#io.opentelemetry.javaagent.shaded.io.opentelemetry.instrumentation"),
"#io.opentelemetry.javaagent.shaded.instrumentation"),
rule(
"#io.opentelemetry.semconv",
"#io.opentelemetry.javaagent.shaded.io.opentelemetry.semconv"),
Expand Down