Optimize tomcat uri construction #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
laurit
reviewed
Aug 29, 2021
| length += 1 + query.length(); | ||
| } | ||
|
|
||
| StringBuilder url = new StringBuilder(length); |
There was a problem hiding this comment.
I initially thought that as this does not encode any characters it could result in an invalid url (would that actually matter?), but javadoc for HttpServletRequest.getQueryString states that "The value is not decoded by the container" and the same for getRequestURI so as far as I understand this looks good.
There was a problem hiding this comment.
good point, I added a TODO to this method to investigate and document encoding requirement
laurit
approved these changes
Aug 29, 2021
anuraaga
approved these changes
Aug 30, 2021
mateuszrzeszutek
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3699
At least until we resolve #3700
(this particular one is showing up in my benchmarks)