Make empty agent bridged context equal root context #3869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Aug 18, 2021
anuraaga
reviewed
Aug 19, 2021
| @@ -40,6 +40,11 @@ | |||
| private static final Logger logger = LoggerFactory.getLogger(AgentContextStorage.class); | |||
|
|
|||
| public static final AgentContextStorage INSTANCE = new AgentContextStorage(); | |||
There was a problem hiding this comment.
Is it possible to use the extension?
Does it break muzzle?
There was a problem hiding this comment.
Yes, it fails muzzle when older api is used because I call ContextStorage.root() which was just added. Seems like wrapper based approach won't work on older api because Context.root() just returns ArrayBasedContext.root() which we would still need to wrap.
There was a problem hiding this comment.
Replaced call to ContextStorage.root() with method handle, @anuraaga could you review.
mateuszrzeszutek
approved these changes
Aug 19, 2021
anuraaga
approved these changes
Aug 20, 2021
trask
approved these changes
Aug 20, 2021
Comment on lines
+107
to
+108
| // APPLICATION_ROOT is null when this method is called while the static initializer is | ||
| // initializing the value of APPLICATION_ROOT field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside agent
Context.current() == Context.root()when context is empty. The same holds when using sdk without agent. It seems reasonable to assume that this should also hold when using sdk with agent.