Use valid Java identifiers for message keys #3863
Conversation
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
|
|
||
| private final ContextPropagators propagators; | ||
| private final Instrumenter<MessageWithChannel, Void> instrumenter; | ||
|
|
||
| // TODO (trask): optimize for javaagent by using field-backed context store | ||
| private final Cache<MessageChannel, ContextAndScope> sendContextAndScopeHolder = |
There was a problem hiding this comment.
Isn't MessageChannel a shared object that is used to send many possibly concurrent messages?
There was a problem hiding this comment.
If the underscore idea doesn't work out, here's another take on this problem that I considered when developing this instrumentation: 7c8d614
| @@ -22,12 +23,16 @@ | |||
| import org.springframework.util.LinkedMultiValueMap; | |||
|
|
|||
| final class TracingChannelInterceptor implements ExecutorChannelInterceptor { | |||
| private static final String CONTEXT_AND_SCOPE_KEY = ContextAndScope.class.getName(); | |||
| private static final String SCOPE_KEY = TracingChannelInterceptor.class.getName() + ".scope"; | |||
There was a problem hiding this comment.
From what I understand dot is invalid, underscore would be fine
There was a problem hiding this comment.
👍 I'll try that. Any idea what a non-serializable message header even means tho?
There was a problem hiding this comment.
This is a very good question. In our test with rabbitmq https://github.com/spring-projects/spring-amqp/blob/bd088731b08ceb7ca90543e18b19cbf70a21c6c8/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/support/DefaultMessagePropertiesConverter.java#L184 converts it to string by calling toString. For actual jms I guess the relevant part is https://github.com/spring-projects/spring-integration/blob/590fb01743d537f3436bccf3a8c445c51b7640d1/spring-integration-jms/src/main/java/org/springframework/integration/jms/DefaultJmsHeaderMapper.java#L133 which seems to ignore properties of unknown type. Though this doesn't explain how there is an exception with IBM MQ, there must be some other place where property is set on jms message. Even if we correct the property name it is likely to still fail as https://docs.oracle.com/javaee/5/api/javax/jms/Message.html#setObjectProperty(java.lang.String,%20java.lang.Object) does not accept arbitrary objects (assuming that this is the method that caused original exception).
This reverts commit c5a4e5e.
trask
changed the title
|
let's try this simple fix, and revisit if needed |
This is causing error on IBM MQ:
Probably could rename to "valid" header name, but seems better not to use message header for local propagation.