record exception in dubbo inst #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydhot
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
reviewed
Aug 16, 2021
| @@ -46,6 +46,9 @@ public Context startClientSpan(String interfaceName, String methodName) { | |||
| } | |||
|
|
|||
| public void end(Context context, Result result) { | |||
| if (result.hasException()) { | |||
There was a problem hiding this comment.
If you do this, then you don't need to handle span status below.
iNikem
approved these changes
Aug 16, 2021
mateuszrzeszutek
approved these changes
Aug 16, 2021
|
@iNikem @mateuszrzeszutek hi, it seemed that there is a windows smoke test failed. I have no idea about this, what should I do to fix it? |
|
Looks like a random failure - I reran all checks, hope they pass this time. |
|
@mateuszrzeszutek thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.