Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish muzze plugins to Gradle Plugin Portal only when manually requested #3763

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Aug 3, 2021

Restored publishing to Sonatype OSS repository on every change

…ested.

Restored publishing to Sonatype OSS repository on every change

tasks {
publishPlugins {
enabled = !version.toString().contains("SNAPSHOT")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should version above be changed back to SNAPSHOT for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really want to publish this to Gradle Portal. The whole idea of the previous PR was to achieve that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is enabled setting here needed, since we only run publishPlugins from manual workflow? is it just for safety?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly for safety, yes. I tried to disable publishToSonatype as well, but it gradle did not find such task :( Probably some evaluation order or rule magic :(


tasks {
publishPlugins {
enabled = !version.toString().contains("SNAPSHOT")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is enabled setting here needed, since we only run publishPlugins from manual workflow? is it just for safety?

@anuraaga
Copy link
Contributor

anuraaga commented Aug 4, 2021

Just want to confirm we're still aiming to end up in a state where we publish gradle plugins with the same version as the repo, along with the normal release-build?

@iNikem
Copy link
Contributor Author

iNikem commented Aug 4, 2021

Just want to confirm we're still aiming to end up in a state where we publish gradle plugins with the same version as the repo, along with the normal release-build?

I don't have any objections to this goal. I don't have clarity about achieving this goal and will need some help.

@anuraaga
Copy link
Contributor

anuraaga commented Aug 4, 2021

I don't have any objections to this goal. I don't have clarity about achieving this goal and will need some help.

Cool - once things settle down with the folder I'll give it a stab. I guess after this PR? :)

@iNikem iNikem merged commit 32351d0 into open-telemetry:main Aug 4, 2021
@iNikem iNikem deleted the gradle-plugins-snapshot branch August 4, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants