Handle port and IPv6 in forwarded headers #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
iNikem
approved these changes
Jul 22, 2021
laurit
reviewed
Jul 22, 2021
| if (forwarded.length() == start) { | ||
| return null; | ||
| } | ||
| if (forwarded.charAt(start) == '[') { |
There was a problem hiding this comment.
Looking at https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded and https://www.rfc-editor.org/rfc/rfc7239 it seems to me that ipv6 addresses need to be quoted, for example for="[2001:db8:cafe::17]". Similarly when ipv4 address includes a port it should be quoted "192.0.2.43:47011"
There was a problem hiding this comment.
good catch, fixed, and yet more tests added...
laurit
approved these changes
Jul 23, 2021
|
Should we add the same thing to the Instrumenter API? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.