Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move instrumentation specific classes out of javaagent-instrumentatio… #3604

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Move instrumentation specific classes out of javaagent-instrumentatio… #3604

merged 1 commit into from
Jul 27, 2021

Conversation

mateuszrzeszutek
Copy link
Member

…n-api

@mateuszrzeszutek mateuszrzeszutek marked this pull request as draft July 16, 2021 16:07
@mateuszrzeszutek
Copy link
Member Author

mateuszrzeszutek commented Jul 16, 2021 •
edited
Loading

Making it a draft for now - gradle doesn't see those bootstrap modules as unique and produces a broken javaagent jar.
Okay, it's fixed now

@mateuszrzeszutek mateuszrzeszutek force-pushed the move-instrumentation-specific-classes-out-of-javaagent-instrumentation-api branch from d2e914b to 4669004 Compare July 27, 2021 08:48
@mateuszrzeszutek mateuszrzeszutek marked this pull request as ready for review July 27, 2021 08:48
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Jul 27, 2021
Merged
trask
trask approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@trask trask merged commit ed9e1a0 into open-telemetry:main Jul 27, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the move-instrumentation-specific-classes-out-of-javaagent-instrumentation-api branch July 28, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNikem iNikem iNikem approved these changes

@trask trask trask approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jkwatson jkwatson Awaiting requested review from jkwatson

@laurit laurit Awaiting requested review from laurit

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateuszrzeszutek @trask @iNikem