Hibernate: set span name only on method entry #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Jul 26, 2021
| @@ -72,7 +78,6 @@ public static void startMethod( | |||
| @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class) | |||
| public static void endMethod( | |||
| @Advice.Thrown Throwable throwable, | |||
| @Advice.Return(typing = Assigner.Typing.DYNAMIC) Object entity, | |||
| @Advice.Origin("#m") String name, | |||
There was a problem hiding this comment.
Suggested change
| @Advice.Origin("#m") String name, |
iNikem
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes updating span name on method exit, we don't need to inspect the return value of method to know what entity is being operated on. Also instead of trying to figure out whether the first argument of a method is String representing requested entity name or an Object representing entity make things a bit more explicit by using method descriptor. If we know that the first argument of method is a String use it as entity name, if it is an Object then it must be an entity and ask hibernate what its name is.