Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Semantic conventions in RabbitMQ #3425

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Conversation

RashmiRam
Copy link
Contributor

@RashmiRam RashmiRam commented Jun 28, 2021

  1. Constructed producer span name according to spec rule. (Removed routing key as part of span name)
  2. Renamed routing key attribute(part of experiment span attributes feature) according to semantic convention

Fixes #3337

1. Constructed producer span name according to spec rule. (Removed routing key as part of span name)
2. Renamed routing key attribute(part of experiment span attributes feature) according to semantic convention
@@ -66,7 +66,9 @@ public Context startGetSpan(
SemanticAttributes.MESSAGING_DESTINATION,
normalizeExchangeName(response.getEnvelope().getExchange()));
if (CAPTURE_EXPERIMENTAL_SPAN_ATTRIBUTES) {
spanBuilder.setAttribute("rabbitmq.routing_key", response.getEnvelope().getRoutingKey());
spanBuilder.setAttribute(
SemanticAttributes.MESSAGING_RABBITMQ_ROUTING_KEY,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this attribute is already a part of the "official" semantic convention, then it is not experimental anymore and should be moved outside this if.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@iNikem iNikem merged commit 15a6428 into open-telemetry:main Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review RabbitMQ instrumentation's semantic conventions usage
4 participants