Fix PeerServiceAttributesExtractor#createUsingReflection() #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
anuraaga
reviewed
Jun 22, 2021
anuraaga
approved these changes
Jun 23, 2021
trask
approved these changes
Jun 23, 2021
laurit
approved these changes
Jun 23, 2021
mateuszrzeszutek
deleted the
fix-PeerServiceAttributesExtractor-reflection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeerServiceAttributesExtractoris located in the bootstrap classloader, allNetAttributesExtractorimplementations are in the application classloaders - we need to pass the application classloader (from any helper class that was already injected) to make loading extractors correctly possible.@anuraaga WDYT about moving
NetAttributeExtractorlibrary implementations to their respectiveinternalpackages and just using those classes normally, without this hack?