Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peer.service to grpc javaagent instrumentation #3357

Merged

Conversation

mateuszrzeszutek
Copy link
Member

I must have missed that one instrumentation when I was adding PeerServiceAttributesExtractor

@trask trask merged commit ab70872 into open-telemetry:main Jun 19, 2021
@NickEm
Copy link

NickEm commented Jul 27, 2021

Hey team,
Is there any chance of patching this to the 1.3.2 version or smth like that?
I mean we are afraid of going to -alpha versions of 1.4.0 so would like to have it in one of the stable 1.3.X

@trask
Copy link
Member

trask commented Jul 28, 2021

I mean we are afraid of going to -alpha versions of 1.4.0 so would like to have it in one of the stable 1.3.X

hey @NickEm, 1.4.0 was released last week, can you clarify what you mean by -alpha version of 1.4.0?

@NickEm
Copy link

NickEm commented Jul 28, 2021

Hi @trask,
Yeah, this is completelly my own confusion. I looked into artifacts like opentelemetry-proto, opentelemetry-api-metrics,opentelemetry-sdk-metrics and saw only 1.4.0-alpha, no stable ones, I hadn't considered they all are alpha latelly, but all the others like opentelemetry-api stable. Sorry for that.
Thank you for clarifiyng and doing good stuff!

@trask
Copy link
Member

trask commented Jul 28, 2021

no worries 👍

@mateuszrzeszutek mateuszrzeszutek deleted the add-peer-service-to-grpc branch November 18, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants