Make @RabbitListener propagate context properly #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Jun 16, 2021
| extends MessagingAttributesExtractor<Message, Void> { | ||
| @Override | ||
| protected String system(Message message) { | ||
| return "rabbitmq"; |
There was a problem hiding this comment.
maybe we should rename this module to spring-amqp-rabbitmq?
There was a problem hiding this comment.
Hmm, I'll rename it to spring-rabbit - this is the name of the library that actually contains AbstractMessageListenerContainer
laurit
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2822
Fixes #2436
It turns out that the
BlockingQueueConsumerclass that I've discovered while working on the spring-integration instrumentation was the cause behind this. Similar to spring-integration, I've added another CONSUMER span that will now propagate its context forward to the actual user listener code.