Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite global ignores matcher to IgnoredTypesConfigurer #3298

Merged

Conversation

mateuszrzeszutek
Copy link
Member

Continuation of #3219

IgnoreMatcherProvider is going to disappear in the next PR by the way 😛

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

import net.bytebuddy.description.type.TypeDescription;
import net.bytebuddy.matcher.ElementMatcher;

class IgnoredTypesMatcher extends ElementMatcher.Junction.AbstractBase<TypeDescription> {
public class IgnoredTypesMatcher extends ElementMatcher.Junction.AbstractBase<TypeDescription> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this was made public for access from the benchmark. Better to move the benchmark into the same package

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also used in the AgentInstaller. I thought that it'd be a bit more useful to expose the constructed trie from the builder, the instrumented classes check could use that one in one of the later PRs.

@mateuszrzeszutek mateuszrzeszutek merged commit 314ba8c into open-telemetry:main Jun 15, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the ignored-types-part-2 branch June 15, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants