Rename ComponentInstaller to AgentListener and add #order() method #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
I wasn't sure about using "safe" service loader for everything, since the safety is only needed currently for instrumentation modules that are compiled with newer Java versions, but I could imagine other SPI implementations also only applying to newer Java versions, so seems good 👍
javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/AgentListener.java
Outdated
Show resolved
Hide resolved
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/SafeServiceLoader.java
Show resolved
Hide resolved
iNikem
reviewed
Jun 7, 2021
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/SafeServiceLoader.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
agent-listener
branch
from
ae459fa to
644213b
Compare
iNikem
approved these changes
Jun 7, 2021
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/SafeServiceLoader.java
Outdated
Show resolved
Hide resolved
…ling/SafeServiceLoader.java Co-authored-by: Nikita Salnikov-Tarnovski <[email protected]>
robododge
pushed a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 17, 2021
…pen-telemetry#3182) * Rename ComponentInstaller to AgentListener and add #order() method * Code review comments * Update javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/SafeServiceLoader.java Co-authored-by: Nikita Salnikov-Tarnovski <[email protected]> Co-authored-by: Nikita Salnikov-Tarnovski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AgentExtensionfrom the...extension.spito...extensionpackage -- we already have SPIs in other packages (...instrumentation) and there's also a note about it in the class JavadocOrderedinterface, now implemented by several SPIs