Fix flaky spring webflux tests #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
This was referenced May 31, 2021
Closed
Closed
tylerbenson
pushed a commit
to DataDog/dd-trace-java
that referenced
this pull request
Jun 2, 2021
tylerbenson
pushed a commit
to DataDog/dd-trace-java
that referenced
this pull request
Jun 11, 2021
From open-telemetry/opentelemetry-java-instrumentation#3150, but rebased with changes from #2791. Thanks to @laurit for your help.
robododge
pushed a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes flaky spring webflux tests. As far as I understand the problem is that reactive flow can get canceled (cancellation happens because request is already considered to be completed) before
SpanFinishingSubscriberis run so that span remains unfinished. This pr adds handling of cancellation.