Akka propagation fix and concurrency tests #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoallikmaa
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
May 27, 2021
Comment on lines
+81
to
+83
| Propagation entry = i.next(); | ||
| sb.append("\ncarrier of type: ").append(entry.carrierClassName); | ||
| for (StackTraceElement ste : entry.location) { |
iNikem
approved these changes
May 27, 2021
laurit
approved these changes
May 27, 2021
agoallikmaa
force-pushed
the
akka-fix-and-concurrency-tests
branch
from
aa6c829 to
354250a
Compare
trask
approved these changes
May 27, 2021
robododge
pushed a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mailboxwhich caused context leak and broke concurrency tests due to the validation inContextPropagationDebug. The class name of theMailboxisakka.dispatch.Dispatcher$$anon$1as it is created inakka.dispatch.Dispatcher#createMailboxusingwith <trait>syntax which actually creates an anonymous class. Excluded it based on that name for now as for the versions currently being tested, this is the only anonymous class present in that file.high concurrency testfor AkkaHttpServerTestandHttpClientTestimplementations.ContextPropagationDebugto record not just the stack trace of each propagation, but the name of the class that carried the context. This made it much simpler to debug what classes we actually attach the context to.