Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove khttp instrumentation #3087

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Remove khttp instrumentation #3087

merged 2 commits into from
Jun 1, 2021

Conversation

anuraaga
Copy link
Contributor

The project doesn't seem to really be maintained. I think presence in Maven Central is a reasonable bar for a library to be included in our distro.

mateuszrzeszutek
mateuszrzeszutek approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable releases are hosted on JCenter.

source

Yep, let's remove that one.

trask
trask approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @iNikem #401 (comment)

@anuraaga
Copy link
Contributor Author

@trask Thanks for the reference. Won't merge until @iNikem approves too

iNikem
iNikem suggested changes May 27, 2021
View reviewed changes
Copy link
Contributor

@iNikem iNikem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will ask around if we still need it. Will block this PR for a couple of days until I hear back.

@anuraaga
Copy link
Contributor Author

Thanks @iNikem - also keep in mind the option of adding it back to splunk distro :)

@iNikem
Copy link
Contributor

iNikem commented May 27, 2021

Yes, I remember that :)

@anuraaga
Copy link
Contributor Author

anuraaga commented Jun 1, 2021 •
edited
Loading

Been a few days - statute of limitations expired? :)

iNikem
iNikem approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@iNikem iNikem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, putting my maintainer hat on, I guess it is reasonable to remove it...

@anuraaga anuraaga merged commit 35727bc into open-telemetry:main Jun 1, 2021
robododge pushed a commit to robododge/opentelemetry-java-instrumentation that referenced this pull request Jun 17, 2021
@robododge
Remove khttp instrumentation (open-telemetry#3087)
030db64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@iNikem iNikem iNikem approved these changes

@trask trask trask approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@laurit laurit Awaiting requested review from laurit

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anuraaga @iNikem @trask @mateuszrzeszutek