Fix memory leak on netty #3059
Merged
Fix memory leak on netty #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
May 21, 2021
|
Can you add a comment to the |
mateuszrzeszutek
approved these changes
May 21, 2021
trask
approved these changes
May 21, 2021
| // listener and wrapper. ContextStore works fine when wrapper is stored in a field on original | ||
| // listener, but when listener class is a lambda instead of field it gets stored in a map with | ||
| // weak keys where original listener is key and wrapper is value. As wrapper has a strong | ||
| // reference to original listener this causes a memory leak. |
There was a problem hiding this comment.
Suggested change
| // reference to original listener this causes a memory leak. | |
| // | |
| // also note that it's ok if the value is collected prior to the key, since this cache is only | |
| // used to remove the wrapped listener from the netty future, and if the value is collected prior | |
| // to the key, that means it's no longer used (referenced) by the netty future anyways |
robododge
pushed a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3027
Instead of
ContextStoreuseCachewith weak keys and weak values to store link between original listener and wrapper.ContextStoreworks fine when wrapper is stored in a field on original listener, but when listener class is a lambda instead of field it gets stored in a map with weak keys where original listener is key and wrapper is value. As wrapper has a strong reference to original this causes a memory leak.