Migrate MuzzlePlugin to Java #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
anuraaga
commented
May 17, 2021
|
|
||
| private final Collection<String> skipVersions; | ||
|
|
||
| AcceptableVersions(Collection<String> skipVersions) { |
There was a problem hiding this comment.
Removed unused range parameter
| } | ||
|
|
||
| private static synchronized ClassLoader getOrCreateToolingLoader(Project project) { | ||
| if (TOOLING_LOADER == null) { |
There was a problem hiding this comment.
Switched to normal volatile since we were synchronized anyways
| return TOOLING_LOADER; | ||
| } | ||
|
|
||
| private static ClassLoader classpathLoader( |
| private static RepositorySystemSession newRepositorySystemSession( | ||
| RepositorySystem system, Project project) { | ||
| DefaultRepositorySystemSession session = MavenRepositorySystemUtils.newSession(); | ||
| File muzzleRepo = project.file("build/muzzleRepo"); |
There was a problem hiding this comment.
I could use a normal temp directory like before but figured it's nice to use user temp directory as little as possible for Gradle builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.