Only reset server context if there is a leak. #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Apr 27, 2021
| // possible spans that instrumentation may have added and such frameworks as of now do not | ||
| // have leaks. | ||
| parent = Context.root(); | ||
| } |
There was a problem hiding this comment.
Should we add the same logic to ServerInstrumenter?
There was a problem hiding this comment.
Hmm - I guess it probably should have the logic, let's do it in a separate PR since we might get lucky and solve our context leak issues before migrating to ServerInstrumenter? :P :D
trask
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Resetting to root was always a hack that we accepted out of necessity for leaking instrumentations. But we reached the end of the line :) Context is a shared resource and who knows what's been added to it before we get a chance to create a span, resetting it arbitrarily isn't really allowed. This new version is still not ideal but at least improves the situation a bit.
Fixes #2853
👍
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resetting to root was always a hack that we accepted out of necessity for leaking instrumentations. But we reached the end of the line :) Context is a shared resource and who knows what's been added to it before we get a chance to create a span, resetting it arbitrarily isn't really allowed. This new version is still not ideal but at least improves the situation a bit.
Fixes #2853