JAX-RS ApplicationPath annotation #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
...mentation-api/src/main/java/io/opentelemetry/instrumentation/api/jaxrs/JaxrsContextPath.java
Outdated
Show resolved
Hide resolved
...mentation-api/src/main/java/io/opentelemetry/instrumentation/api/jaxrs/JaxrsContextPath.java
Outdated
Show resolved
Hide resolved
.../opentelemetry/javaagent/instrumentation/jaxrs/v2_0/CfxServletControllerInstrumentation.java
Outdated
Show resolved
Hide resolved
...mentation-api/src/main/java/io/opentelemetry/instrumentation/api/jaxrs/JaxrsContextPath.java
Outdated
Show resolved
Hide resolved
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-payara-testing/src/test/groovy/PayaraRestTest.groovy
Show resolved
Hide resolved
laurit
force-pushed
the
jaxrs-applicationpath
branch
from
dfc902c to
4bd7e60
Compare
mateuszrzeszutek
approved these changes
Apr 20, 2021
trask
approved these changes
Apr 21, 2021
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-payara-testing/jaxrs-2.0-payara-testing.gradle
Show resolved
Hide resolved
...rumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-arquillian-testing/jaxrs-2.0-arquillian-testing.gradle
Show resolved
Hide resolved
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-tomee-testing/jaxrs-2.0-tomee-testing.gradle
Show resolved
Hide resolved
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-payara-testing/src/test/resources/arquillian.xml
Show resolved
Hide resolved
...t-tooling/src/main/java/io/opentelemetry/javaagent/tooling/matcher/GlobalIgnoresMatcher.java
Outdated
Show resolved
Hide resolved
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-tomee-testing/src/test/resources/logback.xml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span names from jax-rs should contain value of
ApplicationPathannotation or the path where jax-rs servlet is mapped (implementations change servlet mapping based onApplicationPath). Adds tests that run on jetty and bootstrap jax-rs from aServletContainerInitializerbecause this is the only place that actually usesApplicationPathannotation. Also adds tests for tomee (uses cxf) and payara (uses jersey) besides the existing wildfly (uses resteasy) test to verify that the value fromApplicationPathis added to span name in ee applications.