Remove forward and include spans #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Apr 19, 2021
| @@ -554,30 +533,6 @@ abstract class HttpServerTest<SERVER> extends InstrumentationSpecification imple | |||
| } | |||
| } | |||
|
|
|||
| void forwardSpan(TraceAssert trace, int index, Object parent, String errorMessage = null, Class exceptionClass = Exception) { | |||
trask
requested review from
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Apr 19, 2021
|
last call, will merge this tomorrow if no other feedback 😄 |
anuraaga
approved these changes
Apr 21, 2021
mateuszrzeszutek
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see much value in these spans.
Proposing to remove them, or disable them by default.