Add runtime.jvm.gc.count metric #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbarny
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
|
|
iNikem
approved these changes
Mar 22, 2021
felixbarny
commented
Mar 22, 2021
.../library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/GarbageCollector.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Mar 22, 2021
trask
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
hey @felixbarny, good to see you here!
anyone have any objections to renaming these:
- runtime.jvm.gc.collection -> runtime.jvm.gc.time
- runtime.jvm.gc.collection.count -> runtime.jvm.gc.count
we haven't declared stability of metric names, so it's ok for us to rename existing metrics, and I think these are both shorter and clearer
I can do this in a follow-up PR also.
felixbarny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OTel agent already reports the collection time per GC.
The collection count can be useful to compare the count and the duration to see if there are a lot of short GCs or few long GCs, for example.
Please let me know whether you think adding the collection count would also be interesting for OTel.
Background: I'm working for Elastic and we're trying to convert the OTel semantic convention attributes to the Elastic Common Schema so that users can use the OTel agent with the Elastic Stack and the Elastic APM UI. As a part of that effort, we also want to convert the metrics (see elastic/apm-server#4919). We have a screen in our UI displays JVM runtime metrics. One of the charts uses not only the collection time but also the collection count per GC.