Move attributes to span builder for use by samplers #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Mar 17, 2021
Comment on lines
+35
to
+36
| request.setAttribute("traceId", spanContext.getTraceId()); | ||
| request.setAttribute("spanId", spanContext.getSpanId()); |
There was a problem hiding this comment.
I'll send a follow-up PR to change these attribute names to trace_id and span_id to match logging MDC attribute names.
trask
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
iNikem
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the majority of attributes in
HttpClientTracerandHttpServerTracerfrom being set onSpanto being set onSpanBuilder, which allows these attributes to be used by samplers.Fixes #388