Fix prematurely ending server span on undertow #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
|
thanks for the fix @laurit. I will have a look at this shortly. |
|
Maybe there could be a test that adds a filter and verifies that span is recording events after the |
iNikem
reviewed
Mar 11, 2021
| @@ -4,7 +4,8 @@ muzzle { | |||
| pass { | |||
| group = "io.undertow" | |||
| module = 'undertow-core' | |||
| versions = "[2.0.0.Final,)" | |||
| versions = "[1.4.0.Final,)" | |||
There was a problem hiding this comment.
Change README as well, please
There was a problem hiding this comment.
added undertow to supported-libraries.md
There was a problem hiding this comment.
can you rename the module from undertow to undertow-1.4?
...-api/src/main/java/io/opentelemetry/instrumentation/api/undertow/UndertowRequestContext.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Mar 12, 2021
| @@ -4,7 +4,8 @@ muzzle { | |||
| pass { | |||
| group = "io.undertow" | |||
| module = 'undertow-core' | |||
| versions = "[2.0.0.Final,)" | |||
| versions = "[1.4.0.Final,)" | |||
There was a problem hiding this comment.
can you rename the module from undertow to undertow-1.4?
...ain/java/io/opentelemetry/javaagent/instrumentation/api/undertow/UndertowRequestContext.java
Outdated
Show resolved
Hide resolved
...ain/java/io/opentelemetry/javaagent/instrumentation/api/undertow/UndertowRequestContext.java
Outdated
Show resolved
Hide resolved
...ain/java/io/opentelemetry/javaagent/instrumentation/api/undertow/UndertowRequestContext.java
Outdated
Show resolved
Hide resolved
...ain/java/io/opentelemetry/javaagent/instrumentation/api/undertow/UndertowRequestContext.java
Outdated
Show resolved
Hide resolved
instrumentation/undertow/javaagent/src/test/groovy/UndertowServerTest.groovy
Outdated
Show resolved
Hide resolved
instrumentation/undertow/javaagent/src/test/groovy/UndertowServerTest.groovy
Outdated
Show resolved
Hide resolved
instrumentation/undertow/javaagent/src/test/groovy/UndertowServerTest.groovy
Outdated
Show resolved
Hide resolved
…verTest.groovy Co-authored-by: Trask Stalnaker <[email protected]>
…verTest.groovy Co-authored-by: Trask Stalnaker <[email protected]>
mateuszrzeszutek
approved these changes
Mar 12, 2021
pavolloffay
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2499
Currently we end server span on undertow from
ExchangeCompletionListenerwhich is called when response is sent to the client. This may happen before request processing code has completed. Change span ending logic so that span is ended when all handlers have exited and exchange has been completed.@pavolloffay could you verify that this fixes the issue you had